Repository navigation
Seat sign-in: QR only for seats 2–4, and the player's picture next to every controller (#612) - #643
Merged
Merged
Conversation
On the desktop app, P2's Sign in with Discord also opened the sign-in page in the PC's own browser. That browser is signed in to P1's Discord, so it offered to authorize as P1, on top of P2's card with its QR. Seats 2–4 now show only the QR and code; P1's own sign-in still opens the browser. smoke:seat-signin checks P2's Sign in opens nothing (27/27). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDbZGpw6sYifCAPwfQc5vX
|
d28f112 saved the CSS escape '\1F512\A0' as a control byte + text (and a NUL, which also made git treat index.html as binary). Restores the escape; line endings unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDbZGpw6sYifCAPwfQc5vX
…roller (#612) Pete liked P2's Discord name on the seat and asked for the picture and the sign-in's icon next to it, for Player 1 too, everywhere the controller shows. - shared/ui synced to @usersfirst/ui 0.6.0 (lab #143: uf-person; uf-seat pic/source; roster rows' person). Also brings 0.5's achievement elements. - Lobby.seatPerson(n): P1 = the game's account, its Steam sign-in first in the Steam app, Discord first elsewhere; seats 2–4 = their own Discord sign-ins. Name is the account's. - Shown on: the co-op host seats + controller strip, the versus seats + strip, the online room bar (you), the Controls sheet seat + roster, and the Dressing Room card titles. The controller's name moves under the person. - smoke:seat-signin 34/34 (P2 Discord on card, seat, strip; P1 Steam card; Steam app leads with Steam, web with Discord); smoke:versus 39/39, smoke:wardrobe 80/80, unit 825. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDbZGpw6sYifCAPwfQc5vX
petegordon
changed the title
petegordon
added a commit
that referenced
this pull request
Nov 7, 2026
Promote main → steam-publishing (#643 seat sign-in + player pictures)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Seats 2–4 sign in by QR only. When P2 pressed Sign in with Discord in the Dressing Room, the desktop app also opened Discord's sign-in page in the PC's own browser. That browser is signed in to Pete's Discord ("Signed in as petegordon"), so pressing Authorize would have put P1's account on P2's seat. Seats 2–4 now use only the QR and code on their card. P1's own sign-in still opens the browser.
2. The player next to the controller. Pete liked seeing P2's Discord name on the seat, and asked for the picture and the sign-in's icon next to it, for Player 1 too, everywhere a controller shows.
shared/uiis synced to @usersfirst/ui 0.6.0 from lab PR ui 0.6: uf-person on seats and controller rosters UsersFirst/tandemonium-controller-lab#143. That addsuf-person(picture, Discord or Steam badge, name),picandsourceonuf-seat, and apersonfield on roster rows. The sync also brings in 0.5's achievement elements; nothing here uses them yet.Lobby.seatPerson(n). P1 is the game's own account: its Steam sign-in comes first in the Steam app, Discord first everywhere else. Seats 2–4 use their own Discord sign-ins. The name shown is the account name.3. Fixes the locked outfit label "□F512�A0Robot". d28f112 saved the CSS escape for 🔒 as a control byte plus a NUL. The NUL also made git treat
index.htmlas binary. The escape is restored and line endings are unchanged.Tests:
smoke:seat-signin34/34: P2 opens no browser; P2's Discord picture shows on the card, the seat and the strip; P1's Steam picture shows on the card; P1 leads with Steam in the Steam app and Discord on the web.smoke:versus39/39,smoke:wardrobe80/80, unit tests 825.Merge order: lab #143 first. This PR already carries the synced files, so nothing needs re-syncing.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VDbZGpw6sYifCAPwfQc5vX